fix: remove endpoint variables #225
Conversation
|
/run pipeline |
|
/run pipeline |
shemau
left a comment
shemau
left a comment
There was a problem hiding this comment.
Looks good to me. Requires that DA uses private endpoints for SM.
But, DA has properties in ./ibm_catalog.json that will require update (removal). Which raises the issue of migration for any customer who has already deployed with public.
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
The upgrade test will no longer work with this change until we have support to run upgrade test in schematics (which is another week or two out).
One thing we could do is hide them in the ibm_catalog.json so catalog consumers cant use them, but we can still use them in the code. And then when we have schematics upgrade test support, we can fully remove them?
|
This PR is no longer required, since it was implemented elsewhere. A check against main branch today shows that this code is in the |
Description
Remove the endpoint variables from the module calls to Secrets Manager and KMS modules and hard-code the value in the call to be private in order to follow a secure-by-default approach without allowing changes to this.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Removed
existing_secrets_endpoint_type,allowed_network, andkms_endpoint_typeto require these values always be pointing to private endpoints/networkRun the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers